Skip to content

Add LLVM::Builder#finalize #14892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 3 commits into from
Aug 14, 2024
Merged

Add LLVM::Builder#finalize #14892

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
947218b
feat(dispose-builder): add finalize method to LLVM::Builder
JarnaChao09 Aug 12, 2024
3863c19
feat(dispose-builder): run crystal tool format on builder.cr
JarnaChao09 Aug 12, 2024
531fccb
feat(dispose-builder): remove unnecessary disposed check in finalize
JarnaChao09 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/llvm/builder.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,12 @@ class LLVM::Builder
LibLLVM.dispose_builder(@unwrap)
end

def finalize
return if @disposed
Comment thread
JarnaChao09 marked this conversation as resolved.
Outdated

dispose
end

# The next lines are for ease debugging when a types/values
# are incorrectly used across contexts.

Expand Down