Avoid flush in finalizers for Socket and IO::FileDescriptor#14882
Merged
straight-shoota merged 7 commits intocrystal-lang:masterfrom Aug 13, 2024
Merged
Conversation
ysbaddaden
approved these changes
Aug 12, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to flush means that it can try to write, hence call into the event loop, that may have to wait for the fd to be writable, which means calling into
epoll_wait. This all while the world is stopped during a garbage collection run. The event loop implementation may need to allocate, or we get an error and try to raise an exception that will also try to allocate memory... again during a GC collection.For
Socketthis change has little impact becasesyncis true by default which means every byte is sent directly without buffering.IO::FileDescriptor(andFile) is buffered by default, so this may lead to loss of data if you don't properly close the file descriptor after use.Resolves #14807