Update LibCrypto bindings for LibreSSL 3.5+#14872
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Aug 14, 2024
Merged
Update LibCrypto bindings for LibreSSL 3.5+#14872straight-shoota merged 3 commits intocrystal-lang:masterfrom
LibCrypto bindings for LibreSSL 3.5+#14872straight-shoota merged 3 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
changed the title
LibCrypto bindings for LibreSSL 3.5+
straight-shoota
force-pushed
the
feature/ci-alpine-libressl-3.5
branch
from
ed8ac89 to
e8106b9
Compare
ysbaddaden
approved these changes
Aug 13, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layout of the
BIOstruct has changed in LibreSSL 3.5.0. This change reflects that.However, we probably could remove these explicit struct definition as mentioned in #12647 (comment). Its layout is internal to the library and the Crystal bindings only interact with pointers to a bio struct. That'll be a follow-up.
Resolves #12647