Disable Tuple#to_static_array spec on AArch64#14844
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Aug 5, 2024
Merged
Disable Tuple#to_static_array spec on AArch64#14844straight-shoota merged 1 commit intocrystal-lang:masterfrom
Tuple#to_static_array spec on AArch64#14844straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
Member
|
Should we disable the Implementation as well? |
Contributor
Author
|
It is still used in #12960 right? It is probably easier to disallow anything below LLVM 13 when targetting AArch64 |
Member
|
Yes. But other parts of the standard library still work with LLVM < 13 on aarch64. So I'd suggest to use the same macro condition to raise a compile time error in |
Contributor
Author
|
The problem lies not within this method (plus Unfortunately we cannot remove support for LLVM 12 and below on all platforms right away, because Crystal 1.0.0 only supported up to 11. |
straight-shoota
approved these changes
Jul 31, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14835