Skip to content

Disable Tuple#to_static_array spec on AArch64#14844

Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom
HertzDevil:spec/aarch64-tuple-to_static_array
Aug 5, 2024
Merged

Disable Tuple#to_static_array spec on AArch64#14844
straight-shoota merged 1 commit intocrystal-lang:masterfrom
HertzDevil:spec/aarch64-tuple-to_static_array

Conversation

@HertzDevil
Copy link
Contributor

Fixes #14835

@straight-shoota
Copy link
Member

Should we disable the Implementation as well?

@HertzDevil
Copy link
Contributor Author

It is still used in #12960 right? It is probably easier to disallow anything below LLVM 13 when targetting AArch64

@straight-shoota
Copy link
Member

straight-shoota commented Jul 31, 2024

Yes. But other parts of the standard library still work with LLVM < 13 on aarch64. So I'd suggest to use the same macro condition to raise a compile time error in Tuple#to_static_array.
But we can do that independently. This could be good to go on its own.

@HertzDevil
Copy link
Contributor Author

The problem lies not within this method (plus StaticArray#sort_by) but within LLVM itself, I could trigger a crash by simply doing p StaticArray[1, 'a'] so a few methods aren't going to cut it.

Unfortunately we cannot remove support for LLVM 12 and below on all platforms right away, because Crystal 1.0.0 only supported up to 11.

@straight-shoota straight-shoota added this to the 1.14.0 milestone Jul 31, 2024
@straight-shoota straight-shoota merged commit 30d1b01 into crystal-lang:master Aug 5, 2024
@HertzDevil HertzDevil deleted the spec/aarch64-tuple-to_static_array branch August 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Darwin test job fails with macos-14

2 participants