Add WaitGroup.wait and WaitGroup#spawn#14837
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Aug 20, 2024
Merged
Add WaitGroup.wait and WaitGroup#spawn#14837straight-shoota merged 2 commits intocrystal-lang:masterfrom
WaitGroup.wait and WaitGroup#spawn#14837straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
This commit allows for usage of WaitGroup in a way that is significantly
more readable.
Currently, using this API looks like this:
wg = WaitGroup.new(2)
spawn do
http.get "/foo"
ensure
wg.done
end
spawn do
http.get "/bar"
ensure
wg.done
end
wg.wait
With this commit, the code above can be simplified to this:
WaitGroup.wait do |wg|
wg.spawn { http.get "/foo" }
wg.spawn { http.get "/bar" }
end
Contributor
|
I definitely think this should be included as part of the std lib |
straight-shoota
approved these changes
Aug 5, 2024
straight-shoota
requested changes
Aug 5, 2024
Member
straight-shoota
left a comment
straight-shoota
left a comment
There was a problem hiding this comment.
Would you please add some doc comments (ideally with usage examples)?
Contributor
Author
|
Added |
straight-shoota
approved these changes
Aug 6, 2024
ysbaddaden
approved these changes
Aug 19, 2024
straight-shoota
changed the title
WaitGroup usage to be more readableWaitGroup.wait and WaitGroup#spawn
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/is-this-the-only-way-to-terminate/7135/2 |
1 task
Contributor
|
I consider this new usage is really nice. |
jgaskins
added a commit
to jgaskins/http_client
that referenced
this pull request
Sep 2, 2025
This was upstreamed into Crystal: crystal-lang/crystal#14837
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14820