Add documentation for NoReturn and Void#14817
Merged
straight-shoota merged 4 commits intocrystal-lang:masterfrom Aug 19, 2024
Merged
Add documentation for NoReturn and Void#14817straight-shoota merged 4 commits intocrystal-lang:masterfrom
NoReturn and Void#14817straight-shoota merged 4 commits intocrystal-lang:masterfrom
Conversation
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Sija
reviewed
Jul 22, 2024
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Sija
reviewed
Jul 22, 2024
Contributor
Author
|
There's no obvious way to fix the backtick links I can find without stuff that feels like hacks, and it's only a minor issue so I'm marking this as ready for review |
straight-shoota
approved these changes
Aug 6, 2024
Member
|
I think a solution for linking backticks could be to inject |
ysbaddaden
approved these changes
Aug 18, 2024
straight-shoota
changed the title
NoReturn and Void
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13272
It works, and I've copied the
NoReturndocs from the crystal book. Only issue is that the backticks references toNoReturnandVoiddon't work without including both the actual type and the pseudo type, resulting in two of each showing up in the sidebar.