Revert "Optimize JSON parsing a bit"#14804
Merged
straight-shoota merged 1 commit intomasterfrom Jul 11, 2024
Merged
Conversation
This reverts commit 9ef6366.
straight-shoota
added
topic:stdlib:serialization
kind:regression
beta-ziliani
approved these changes
Jul 10, 2024
ysbaddaden
approved these changes
Jul 10, 2024
straight-shoota
added
the
kind:bug
|
Has been #14803 test case added? |
1 task
Member
Author
|
Not yet. It isn't essential for the 1.13.1 release because we know it works. |
|
Sorry, no. (Don't use Crystal.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #14366
Resolves #14803