Add support for negative start index in Slice#[start, count]#14778
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Aug 7, 2024
Merged
Conversation
Member
straight-shoota
left a comment
There was a problem hiding this comment.
suggestion: Describe this additional behaviour in the API docs.
ysbaddaden
commented
Jul 4, 2024
| slice1.should_not be_nil | ||
| slice1 = slice1.not_nil! | ||
| slice1.size.should eq(2) | ||
| slice1.to_unsafe.should eq(slice.to_unsafe + 1) |
Collaborator
Author
There was a problem hiding this comment.
Note: I added tests to verify that the subslice is pointing to the same memory as the original slice, and not returning a copy. This is the expected behavior, but we didn't check it.
straight-shoota
approved these changes
Jul 4, 2024
Slice#[start, count]
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
slice[-3, 3]to return the last 3 elements of the slice, for example, similar to how Array#[-start, count] behaves, with the difference that Slice returns exactly count elements, while Array returns up to count elements.Introduces a couple changes:
I believe the current behavior is buggy (unexpected result, underspecified documentation), but this can be considered a breaking change.
refs #14775