Expose LLVM instruction builder for neg and fneg#14774
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Aug 7, 2024
Merged
Expose LLVM instruction builder for neg and fneg#14774straight-shoota merged 1 commit intocrystal-lang:masterfrom
neg and fneg#14774straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
…initions for neg and fneg instructions
ysbaddaden
approved these changes
Jul 3, 2024
straight-shoota
approved these changes
Jul 3, 2024
neg and fneg
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Exposes the LLVM-C API to build
negandfneginstructionsReason
While the
neginstruction is just a "super instruction" to0 - self,fnegas an instruction maintains NaN-ness inside of the floating point representation which may not be kept by performing0 - self.Notes
LLVMArrayTypevsLLVMArrayType2)