Make ReferenceStorage(T) non-atomic if T is non-atomic#14730
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Jun 22, 2024
Merged
Make ReferenceStorage(T) non-atomic if T is non-atomic#14730straight-shoota merged 2 commits intocrystal-lang:masterfrom
ReferenceStorage(T) non-atomic if T is non-atomic#14730straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Jun 19, 2024
ysbaddaden
approved these changes
Jun 19, 2024
Member
|
We need to skip the spec on the interpreter. |
1 task
straight-shoota
pushed a commit
that referenced
this pull request
Aug 6, 2024
It turns out the fix in #14730 made all `ReferenceStorage` objects non-atomic; `Crystal::ReferenceStorageType#reference_type` returns a reference type, whose `#has_inner_pointers?` always returns true since the reference itself is a pointer. This PR fixes that again by adding a special case for `ReferenceStorage`.
straight-shoota
pushed a commit
that referenced
this pull request
Aug 20, 2024
It turns out the fix in #14730 made all `ReferenceStorage` objects non-atomic; `Crystal::ReferenceStorageType#reference_type` returns a reference type, whose `#has_inner_pointers?` always returns true since the reference itself is a pointer. This PR fixes that again by adding a special case for `ReferenceStorage`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14692.