Skip to content

Enable pending formatter features #14718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 14 commits into from
Oct 10, 2024
Merged

Enable pending formatter features #14718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d2efef7
Ensure trailing commas are not written when parameters are not multi-…
Blacksmoke16 Jun 14, 2024
ed29b77
Enable trailing comma formatter feature
Blacksmoke16 Jun 15, 2024
83aabab
Apply trailing comma feature to rest of codebase
Blacksmoke16 Jun 15, 2024
2f66b94
Enable method signature yield formatter feature
Blacksmoke16 Jun 15, 2024
ca76f06
Apply method signature yield feature to rest of codebase
Blacksmoke16 Jun 15, 2024
412db3e
Enable proc literal whitespace formatter feature
Blacksmoke16 Jun 15, 2024
a748a9b
Apply proc literal whitespace feature to rest of codebase
Blacksmoke16 Jun 15, 2024
7d58e0d
Assert before and after instead of just after
Blacksmoke16 Jun 15, 2024
5e6aec5
Drop unused flags in formatter specs
Blacksmoke16 Jun 15, 2024
395a94b
Merge branch 'master' into enable-formatter-features
Blacksmoke16 Jun 16, 2024
711d9e8
Merge master & resolve conflicts
Blacksmoke16 Sep 25, 2024
a81ed39
Adjust formatting rules to always re-format to new styles
Blacksmoke16 Oct 1, 2024
25bbf8f
Merge remote-tracking branch 'origin/master' into enable-formatter-fe…
Blacksmoke16 Oct 1, 2024
135e4b5
Merge master & resolve conflict
Blacksmoke16 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
344 changes: 94 additions & 250 deletions spec/compiler/formatter/formatter_spec.cr
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion spec/llvm-ir/pass-closure-to-c-debug-loc.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def raise(msg)
end

x = 1
f = ->{ x }
f = -> { x }
Foo.foo(f)

# CHECK: define internal i8* @"~check_proc_is_not_closure"(%"->" %0)
Expand Down
2 changes: 1 addition & 1 deletion spec/llvm-ir/proc-call-debug-loc.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
x = ->{}
x = -> { }
x.call
# CHECK: extractvalue %"->" %{{[0-9]+}}, 0
# CHECK-SAME: !dbg [[LOC:![0-9]+]]
Expand Down
2 changes: 1 addition & 1 deletion spec/std/benchmark_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe Benchmark::IPS::Job do
end

private def create_entry
Benchmark::IPS::Entry.new("label", ->{ 1 + 1 })
Benchmark::IPS::Entry.new("label", -> { 1 + 1 })
end

private def h_mean(mean)
Expand Down
Loading