Add flags missing from termios#14652
Conversation
ysbaddaden
left a comment
There was a problem hiding this comment.
There are a few issues to solve beforehand:
- these are non standard (as per https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/termios.h.html);
- there are only bindings for Linux while the other BSD targets also have most of them;
- last but not least, we won't use them in stdlib, and we don't intend to support everything from the C library in the compiler.
|
I agree. The only flag that I was missing in this project in fact was VTIME. It seems to be part of non-canonical mode, like VSTART, VSTOP, etc. What do you think? Should this PR include only VTIME? |
|
There's an ongoing discussion about the status of libc bindings in stdlib (#13504). The general idea is that we don't plan to support any bindings that are not used in stdlib itself. Unused bindings might be removed in the future (#11955). So I don't think it's a good idea to add more unused bindings at this point. If you need specific bindings for your project, it's probably best to define them in your own code. |
|
(I really should just restart my posix shard as a |
|
Closing. We shouldn't add new unused libc bindings to stdlib until there's a decision that we definitely want to maintain them. Collecting such bindings in a shard seems like a good idea. |
Adding flags from c_cc characters section. Refer to https://sites.uclouvain.be/SystInfo/usr/include/bits/termios.h.html