Skip to content

Fix Range#size return type to Int32 #14588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 2 commits into from
Sep 5, 2024
Merged

Fix Range#size return type to Int32 #14588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
466d770
Fix `Rang#size` return type to `Int32`
straight-shoota May 13, 2024
13bfaf4
Add documentation about error behaviour
straight-shoota May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/range.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,15 +482,18 @@ struct Range(B, E)
# (3..8).size # => 6
# (3...8).size # => 5
# ```
def size
#
# Raises `OverflowError` if the difference is bigger than `Int32`.
# Raises `ArgumentError` if either `begin` or `end` are `nil`.
def size : Int32
b = self.begin
e = self.end

# Optimized implementation for int range
if b.is_a?(Int) && e.is_a?(Int)
e -= 1 if @exclusive
n = e - b + 1
n < 0 ? 0 : n
n < 0 ? 0 : n.to_i32
else
if b.nil? || e.nil?
raise ArgumentError.new("Can't calculate size of an open range")
Expand Down