Add src/SOURCE_DATE_EPOCH to release tree#14574
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom May 13, 2024
Merged
Add src/SOURCE_DATE_EPOCH to release tree#14574straight-shoota merged 1 commit intocrystal-lang:masterfrom
src/SOURCE_DATE_EPOCH to release tree#14574straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
beta-ziliani
approved these changes
May 10, 2024
1 task
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/issues-with-crimson-on-windows/7309/16 |
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Crystal compiler version info (
crystal --version) includes a date representing the chronological aspect of the comiler version.It's supposed to represent the date of the source code. But this information is not available in a bare snapshot of the source tree. The
Makefiletries to read the date of the last commit fromgit, which requiresgitand the repository.This patch adds a file
src/SOURCE_DATE_EPOCHwhich sits alongsidesrc/VERSIONto have both data available next to each other.It gets automatically populated in the release process and is removed afterwards. So it should only be available in the source tree of tagged release commits.
A practical use case for this is NixOS/nixpkgs#306765 as well as any other package build that doesn't use the git repository.