Fix generate docs for builtins HOST_TRIPLE and TARGET_TRIPLE#14570
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom May 9, 2024
Merged
Conversation
straight-shoota
added
kind:bug
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/how-to-get-system-and-architecture/6819/2 |
ysbaddaden
approved these changes
May 7, 2024
nobodywasishere
approved these changes
May 7, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we originally added these constants in #13823 we overlooked that we also need to make the doc generator aware they are builtins which should be included in the doc output.
This is of course a bit brittle setup and we should try to find a better solution, but for now this patch fixes that these two constants show up in the API docs.