Fix parsing of non-trailing if bodies inside macro expressions#14505
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Apr 19, 2024
Merged
Fix parsing of non-trailing if bodies inside macro expressions#14505straight-shoota merged 1 commit intocrystal-lang:masterfrom
if bodies inside macro expressions#14505straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Apr 18, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14214.
The
debugin the following will now be aVarinstead of aCall:{% if true debug end %}but it will run just fine because the macro interpreter has a special rule for treating
Vars as top-level macro method calls if the variables do not actually exist.