Skip to content

Implement pagination for GitHub API in github-changelog helper #14412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Apr 2, 2024
Merged

Implement pagination for GitHub API in github-changelog helper #14412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 42 additions & 13 deletions scripts/github-changelog.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,17 @@ api_token = ENV["GITHUB_TOKEN"]
repository = "crystal-lang/crystal"
milestone = ARGV.first

def query_prs(api_token, repository, milestone)
def query_prs(api_token, repository, milestone : String, cursor : String?)
query = <<-GRAPHQL
query($milestone: String, $owner: String!, $repository: String!) {
query($milestone: String, $owner: String!, $repository: String!, $cursor: String) {
repository(owner: $owner, name: $repository) {
milestones(query: $milestone, first: 1) {
nodes {
closedAt
description
dueOn
title
pullRequests(first: 300) {
pullRequests(first: 100, after: $cursor) {
nodes {
number
title
Expand All @@ -50,6 +50,10 @@ def query_prs(api_token, repository, milestone)
}
}
}
pageInfo {
endCursor
hasNextPage
}
}
}
}
Expand All @@ -62,6 +66,7 @@ def query_prs(api_token, repository, milestone)
owner: owner,
repository: name,
milestone: milestone,
cursor: cursor,
}

response = HTTP::Client.post("https://api.github.com/graphql",
Expand Down Expand Up @@ -269,21 +274,45 @@ record PullRequest,
end
end

response = query_prs(api_token, repository, milestone)
parser = JSON::PullParser.new(response.body)
milestone = parser.on_key! "data" do
parser.on_key! "repository" do
parser.on_key! "milestones" do
parser.on_key! "nodes" do
parser.read_begin_array
milestone = Milestone.new(parser)
parser.read_end_array
milestone
def query_milestone(api_token, repository, number)
cursor = nil
milestone = nil

while true
response = query_prs(api_token, repository, number, cursor)

parser = JSON::PullParser.new(response.body)
m = parser.on_key! "data" do
parser.on_key! "repository" do
parser.on_key! "milestones" do
parser.on_key! "nodes" do
parser.read_begin_array
Milestone.new(parser)
ensure
parser.read_end_array
end
end
end
end

if milestone
milestone.pull_requests.concat m.pull_requests
else
milestone = m
end

json = JSON.parse(response.body)
page_info = json.dig("data", "repository", "milestones", "nodes", 0, "pullRequests", "pageInfo")
break unless page_info["hasNextPage"].as_bool

cursor = page_info["endCursor"].as_s
end

milestone
end

milestone = query_milestone(api_token, repository, milestone)

sections = milestone.pull_requests.group_by(&.section)

SECTION_TITLES = {
Expand Down