Fix: Add SA_RESTART flag to sigaction syscall#14351
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Mar 8, 2024
Merged
Fix: Add SA_RESTART flag to sigaction syscall#14351straight-shoota merged 2 commits intocrystal-lang:masterfrom
SA_RESTART flag to sigaction syscall#14351straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
We recently changed from signal(2) to sigaction(2) and some IO related syscalls started failing with EINTR. Reading the different manpages, BSD changed signal(2) to have SA_RESTART semantics, which glibc on Linux followed by not calling the signal syscall but instead calling sigcation with the SA_RESTART flag.
ysbaddaden
added
the
kind:bug
HertzDevil
approved these changes
Mar 7, 2024
HertzDevil
added
topic:stdlib:system
kind:regression
straight-shoota
changed the title
SA_RESTART flag to sigaction syscall
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently changed from signal(2) to sigaction(2) and some IO related syscalls started failing with EINTR.
Reading the different manpages, BSD changed signal(2) to have SA_RESTART semantics, which glibc on Linux followed by not calling the signal syscall but instead calling sigcation with the SA_RESTART flag.
closes #14350