Fix macro Crystal::LIBRARY_PATH.split when cross-compiling#14330
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Feb 29, 2024
Merged
Fix macro Crystal::LIBRARY_PATH.split when cross-compiling#14330straight-shoota merged 2 commits intocrystal-lang:masterfrom
Crystal::LIBRARY_PATH.split when cross-compiling#14330straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
Member
|
I'm wondering if |
straight-shoota
approved these changes
Feb 28, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crystal::LIBRARY_PATHalways uses the host platform's path delimiter, butProcess::PATH_DELIMITERis defined in terms of the target platform, which can break cross-compilation from a non-Windows system to Windows whenCRYSTAL_LIBRARY_PATHhas multiple items. This PR adds the correct delimiter as a constant.By the way, this is actually the first usage of
host_flag?in the repository.