Support asynchronous file I/O on Windows#14321
Closed
HertzDevil wants to merge 12 commits intocrystal-lang:masterfrom
Closed
Support asynchronous file I/O on Windows#14321HertzDevil wants to merge 12 commits intocrystal-lang:masterfrom
HertzDevil wants to merge 12 commits intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:feature
platform:windows
yxhuvud
reviewed
Feb 25, 2024
Contributor
yxhuvud
left a comment
yxhuvud
left a comment
There was a problem hiding this comment.
Nice. Is this the first case of windows functionality being better than the libevent based one?
| end | ||
|
|
||
| bytes_read.to_i64 | ||
| def self.pread(file, buffer, offset) |
Contributor
There was a problem hiding this comment.
It is high time to rename this method as the name refers to a libc call that isn't used on this OS.
read_with_offset perhaps?
Member
|
@HertzDevil is this ready for review? |
Contributor
Author
|
missing specs |
This was referenced Aug 20, 2024
Contributor
Author
|
All the progress here has been split into individual PRs that work with the refactored IOCP interface; closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #14255, it is now possible to open non-blocking
Files on Windows, as previously their blocking mode could not be changed after initialization. This PR makes operations on thoseFiles actually work.