Replace some Microsoft C runtime funs with Win32 equivalents#14316
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Feb 23, 2024
Merged
Replace some Microsoft C runtime funs with Win32 equivalents#14316straight-shoota merged 2 commits intocrystal-lang:masterfrom
straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:refactor
platform:windows
straight-shoota
approved these changes
Feb 22, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally we could replace the type of
fdon Windows entirely, similar to howSocket#fdreturns aLibC::HANDLE, in which case we could also drop_close/_dup2/_get_osfhandle/_open_osfhandle. This isn't possible sinceIO::FileDescriptor#fdis public.