Skip to content

Use correct string size for LLVM::Type#inline_asm#14265

Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom
HertzDevil:bug/inline-asm-size
Jan 29, 2024
Merged

Use correct string size for LLVM::Type#inline_asm#14265
straight-shoota merged 1 commit intocrystal-lang:masterfrom
HertzDevil:bug/inline-asm-size

Conversation

@HertzDevil
Copy link
Contributor

Uses bytesize instead of size to avoid truncating the template string if it contains non-ASCII characters.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:llvm labels Jan 28, 2024
@straight-shoota straight-shoota added this to the 1.12.0 milestone Jan 28, 2024
@straight-shoota straight-shoota merged commit de7a078 into crystal-lang:master Jan 29, 2024
@HertzDevil HertzDevil deleted the bug/inline-asm-size branch January 30, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:llvm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants