Do not handle inline assembly with "intel" flag as AT&T syntax#14264
Merged
straight-shoota merged 4 commits intocrystal-lang:masterfrom Jan 29, 2024
Merged
Do not handle inline assembly with "intel" flag as AT&T syntax#14264straight-shoota merged 4 commits intocrystal-lang:masterfrom
"intel" flag as AT&T syntax#14264straight-shoota merged 4 commits intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:bug
HertzDevil
changed the title
"intel" flag as AT&T syntax
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Member
|
suggestion: It might be more future proof for the method parameter to receive an instance of |
straight-shoota
approved these changes
Jan 28, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM understands this parameter and Crystal's parser also supports the
"intel"attribute forAsmnodes, yet actually using the Intel syntax in the template string will produce a codegen error. This PR fixes that, and the emitted LLVM IR will now include theinteldialectoption, e.g.call void asm inteldialect "mov dword ptr [$0], 42", "r"(ptr %x).LLVM's own inline assembler should understand Intel syntax as long as it targets x86. This has nothing to do with whether
--emit=asmwrites the compiled assembly back using Intel syntax.