Move Spec context state into Spec::CLI#14259
Move Spec context state into Spec::CLI#14259straight-shoota merged 2 commits intocrystal-lang:masterfrom
Spec context state into Spec::CLI#14259Conversation
straight-shoota
left a comment
There was a problem hiding this comment.
thought: I'm wondering if the class name CLI is actually a good fit, particularly with these changes. It seems to be more than a command line interface. Maybe a more generic term like Run might be better?
question: It seems the refactoring from print_results to prints_summary? is a prerequisite but not directly related to the context state refactor. Could we separate this?
|
|
|
Not sure I understand what you mean. Wouldn't it be possible to apply the refactor from |
Follow-up to #14170. This includes the global variables inside
Spec::RootContext.