MT: reduce interleaved backtraces in spawn unhandled exceptions#14220
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Jan 24, 2024
Conversation
Instead of doing many individual writes to STDERR, that may happen concurrently with other threads, we can buffer the message in memory so we can write it once.
straight-shoota
approved these changes
Jan 11, 2024
beta-ziliani
approved these changes
Jan 23, 2024
Member
beta-ziliani
left a comment
There was a problem hiding this comment.
My only concern is that if the error comes from memory exhaustion, this would not help. OTOH, if the exception comes from stack exhaustion, then a stack allocated buffer wouldn't help either...
Collaborator
Author
|
You're right @beta-ziliani. Hum, in case of stack exhaustion this will trigger a segfault that will be handled in a signal handler (no exception raised), but for OOM we will get an exception (which also allocates) that we might be able to catch, so we can use a fixed-size stack buffer. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing many individual writes to STDERR that may happen concurrently with other threads, we buffer the message in memory so we can write once.
I tried with 10 000 fibers and 16 threads and I couldn't get any interleaved message. That doesn't mean it can't happen, especially with other concurrent writes to STDERR —which an alternative solution to use a mutex wouldn't prevent it either.
Note: I chose to use a HEAP allocated buffer rather than a stack allocated one because the latter wouldn't be resizeable, and there is no guarantee that the backtrace would fit within 4KB (
PIPE_BUFon Linux).closes #8299