Skip to content

Remove T* and T[N] macro interpolation behavior inside libs#14215

Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom
HertzDevil:bug/lib-short-type-names
Jan 13, 2024
Merged

Remove T* and T[N] macro interpolation behavior inside libs#14215
straight-shoota merged 2 commits intocrystal-lang:masterfrom
HertzDevil:bug/lib-short-type-names

Conversation

@HertzDevil
Copy link
Contributor

Fixes #14213. Reverts 75cd6ce and fbf2eeb.

This disables all such behavior, including inside structs / unions and funs. There is probably no need for Crystal::ToSVisitor to do this.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:lang:macros labels Jan 11, 2024
@straight-shoota straight-shoota added this to the 1.12.0 milestone Jan 11, 2024
@straight-shoota straight-shoota merged commit e0c5301 into crystal-lang:master Jan 13, 2024
@HertzDevil HertzDevil deleted the bug/lib-short-type-names branch January 26, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:lang:macros

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Macro interpolation of Void* constant inside lib is broken

2 participants