Skip to content

Remove extra newline in top-level FunDef's string representation #14212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Jan 12, 2024
Merged

Remove extra newline in top-level FunDef's string representation #14212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spec/compiler/parser/to_s_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ describe "ASTNode#to_s" do
expect_to_s %(@[Foo(1, 2, a: 1, b: 2)])
expect_to_s %(lib Foo\nend)
expect_to_s %(lib LibC\n fun getchar(Int, Float)\nend)
expect_to_s %(fun foo(a : Void, b : Void, ...) : Void\n\nend)
expect_to_s %(fun foo(a : Void, b : Void, ...) : Void\nend)
expect_to_s %(fun foo\nend)
expect_to_s %(lib Foo\n struct Foo\n a : Void\n b : Void\n end\nend)
expect_to_s %(lib Foo\n union Foo\n a : Int\n b : Int32\n end\nend)
expect_to_s %(lib Foo\n FOO = 0\nend)
Expand Down
1 change: 0 additions & 1 deletion src/compiler/crystal/syntax/to_s.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,7 +1170,6 @@ module Crystal
if body = node.body
newline
accept_with_indent body
newline
append_indent
@str << "end"
end
Expand Down