Always call LibXML.xmlInitParser when requiring XML libraries#14191
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Jan 12, 2024
Merged
Always call LibXML.xmlInitParser when requiring XML libraries#14191straight-shoota merged 1 commit intocrystal-lang:masterfrom
LibXML.xmlInitParser when requiring XML libraries#14191straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Jan 9, 2024
Member
straight-shoota
left a comment
straight-shoota
left a comment
There was a problem hiding this comment.
This seems like a decent change, regardless of whether it fixes the macOS issues.
HertzDevil
changed the title
LibXML.xmlInitParser when requiring XML filesLibXML.xmlInitParser when requiring XML libraries
Member
|
I confirm this solves the issue with macOS own libXML 👏 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may fix #10365. I need more confirmation from macOS users.
libxml2 used to have a lot of different initialization functions, and will usually call one of them itself when a client calls any XML function. My guess is those initializations by libxml2 weren't enough in older versions (this is probably why all of them except
xmlInitParserare deprecated nowadays).