Refactor Spec.run to macro finished#14122
Draft
straight-shoota wants to merge 4 commits intocrystal-lang:masterfrom
Draft
Refactor Spec.run to macro finished#14122straight-shoota wants to merge 4 commits intocrystal-lang:masterfrom
Spec.run to macro finished#14122straight-shoota wants to merge 4 commits intocrystal-lang:masterfrom
Conversation
This should be largely equivalent to the current solution with `at_exit` but more robust because it does not conflict with libraries' `at_exit` handlers.
straight-shoota
force-pushed
the
refactor/spec-run
branch
from
7f2ee51 to
df305b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be largely equivalent to the current solution with
at_exitbut more robust because it does not conflict with libraries'at_exithandlers.Resolves #14121