Move Thread#set_current_thread to Fiber#14099
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Dec 20, 2023
Merged
Move Thread#set_current_thread to Fiber#14099straight-shoota merged 1 commit intocrystal-lang:masterfrom
Thread#set_current_thread to Fiber#14099straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
This avoids manipulating `fiber.@current_thread` which ain't very pretty. Crystal::Scheduler is now entirely responsible for setting the current thread. It's also responsible to verify that a making sure a fiber will always be enqueued or resumed on the thread it's been associated to, which is only affecting the `#resume(fiber)` and `#yield(fiber)` methods that are barely used. Lastly, we remove the current_thread store that was always replacing any previous value on context swap. Sadly, this doesn't seem to have any noticeable impact on performance.
bcardiff
approved these changes
Dec 19, 2023
straight-shoota
approved these changes
Dec 19, 2023
straight-shoota
changed the title
Thread#set_current_thread to Fiber
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids manipulating
fiber.@current_threadwhich ain't very pretty.Crystal::Scheduler is now entirely responsible for setting the current thread. It's also responsible to verify that a making sure a fiber will always be enqueued or resumed on the thread it's been associated to, which is only affecting the
#resume(fiber)and#yield(fiber)methods that are barely used.Lastly, we remove the current_thread store that was always replacing any previous value on context swap. Sadly, this doesn't seem to have any noticeable impact on performance.