Do not remove trailing comma from multi-line macro/def parameters (not yet enabled)#14075
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Dec 12, 2023
Merged
Conversation
Blacksmoke16
added
kind:bug
straight-shoota
approved these changes
Dec 8, 2023
HertzDevil
requested changes
Dec 9, 2023
HertzDevil
approved these changes
Dec 11, 2023
straight-shoota
added
kind:feature
and removed
kind:bug
straight-shoota
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior is behind the
def_trailing_commaflag as per #13002. Once we go to remove the flag, will need to go and update all the existing formatter specs that it's not currently enabled for. At that point can probably just remove the specs I added as pretty sure they're handled via other assertions.Fixes #13169