Enable more std tests for interpreter#14016
Closed
cyangle wants to merge 9 commits intocrystal-lang:masterfrom
Closed
Enable more std tests for interpreter#14016cyangle wants to merge 9 commits intocrystal-lang:masterfrom
cyangle wants to merge 9 commits intocrystal-lang:masterfrom
Conversation
This is only a workaround to make forking work in interpreter It requires setting env var HANDLE_SIGNAL_IN_INTERPRETER to 1 to enable the workaround
Member
|
What's the point though? I'd rather try to find a fix for #12241 than implement a workaround just to be able to run more specs. |
Contributor
Author
|
Close with alternative workaround #14019 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only a workaround for #12241
It requires setting env var
HANDLE_SIGNAL_IN_INTERPRETERto1to enable the workaroundBelow loop now works without issues:
I think this patch is fine as it's behind a flag and interpreter is still experimental.
@straight-shoota