Add --frame-pointers to control preservation of frame pointers#13860
Merged
straight-shoota merged 4 commits intocrystal-lang:masterfrom Jan 27, 2024
Merged
Add --frame-pointers to control preservation of frame pointers#13860straight-shoota merged 4 commits intocrystal-lang:masterfrom
--frame-pointers to control preservation of frame pointers#13860straight-shoota merged 4 commits intocrystal-lang:masterfrom
Conversation
Contributor
Author
|
As an unrelated aside, I found this in Apple's ARM64 docs:
Could the |
Member
straight-shoota
left a comment
straight-shoota
left a comment
There was a problem hiding this comment.
LGTM. I have left some comments for improvements.
refi64
force-pushed
the
frame-pointers
branch
from
74851ec to
d922664
Compare
Frame pointers are extremely useful for quickly generating accurate stack traces when debugging and profiling release builds. In particular, it allows the use of Linux's perf stack, which offers high-performance profiling but only supports unwinding via frame pointers, barring some extremely slow workarounds: https://blogs.gnome.org/chergert/2022/12/31/frame-pointers-and-other-practical-near-term-solutions/
refi64
force-pushed
the
frame-pointers
branch
from
d922664 to
9257aac
Compare
Sija
reviewed
Nov 9, 2023
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
HertzDevil
requested changes
Nov 27, 2023
Collaborator
|
Nice! I just tested this patch with a program I was analyzing with linux perf tools, and most of the unknown symbols are now explained 🥳 Weirdly I returned to crystal 1.10.1 without the frame pointers, and perf still finds the symbols 🤨 |
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
HertzDevil
approved these changes
Jan 25, 2024
straight-shoota
approved these changes
Jan 26, 2024
straight-shoota
changed the title
--frame-pointers to control preservation of frame pointers
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frame pointers are extremely useful for quickly generating accurate stack traces when debugging and profiling release builds. In particular, it allows the use of Linux's perf stack, which offers high-performance profiling but only supports unwinding via frame pointers, barring some extremely slow workarounds:
https://blogs.gnome.org/chergert/2022/12/31/frame-pointers-and-other-practical-near-term-solutions/