Skip to content

Update Int128/UInt128 documentation to use literals #13697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stufro wants to merge 1 commit into from
Closed

Update Int128/UInt128 documentation to use literals #13697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/int.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,9 +1299,8 @@ struct Int64
end

struct Int128
# TODO: eventually update to literals once UInt128 bit support is finished
MIN = new(1) << 127
MAX = ~MIN
MIN = -170141183460469231731687303715884105728_i128
MAX = 170141183460469231731687303715884105727_i128

# Returns an `Int128` by invoking `to_i128` on *value*.
# See `String#to_i` for more details.
Expand Down Expand Up @@ -1329,8 +1328,7 @@ struct Int128
Number.expand_div [Float64], Float64

def -
# TODO: use 0_i128 - self
Int128.new(0) - self
0_i128 - self
end

# :nodoc:
Expand Down Expand Up @@ -1867,9 +1865,8 @@ struct UInt64
end

struct UInt128
# TODO: eventually update to literals once UInt128 bit support is finished
MIN = new 0
MAX = ~MIN
MIN = 0_u128
MAX = 340282366920938463463374607431768211455_u128

# Returns an `UInt128` by invoking `to_u128` on *value*.
# See `String#to_i` for more details.
Expand Down Expand Up @@ -1897,8 +1894,7 @@ struct UInt128
Number.expand_div [Float64], Float64

def &-
# TODO: use 0_u128 &- self
UInt128.new(0) &- self
0_u128 &- self
end

def abs
Expand Down