Correctly ignore nested deprecation warnings#13513
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Jun 5, 2023
Merged
Correctly ignore nested deprecation warnings#13513straight-shoota merged 1 commit intocrystal-lang:masterfrom
straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
HertzDevil
approved these changes
May 27, 2023
oprypin
changed the title
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13507
This is a very basic implementation to ignore warnigs when calling a deprecated method directly within the body of another deprecated method.
It covers the most common use case.
A more sophisticated approach would take other deprecation scopes into account as well (for example, ignore any deprecation warnings from within a deprecated type). But that requires more complex changes and we're getting already most of the way with this basic implementation.