Fix Array(T)#[]=(Int, Int, Array(T)) on shifted arrays#13275
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Apr 5, 2023
Merged
Fix Array(T)#[]=(Int, Int, Array(T)) on shifted arrays#13275straight-shoota merged 1 commit intocrystal-lang:masterfrom
Array(T)#[]=(Int, Int, Array(T)) on shifted arrays#13275straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
straight-shoota
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is like #13256, except for
#[]=whenever the size of the array increases:After this PR:
This indirectly affects the
Rangeoverload as well, which forwards to this overload.Also as a result of this fix, all resizing operations on
Arraynow grow the buffer consistently using the same policy, unlike previously where some still useMath.pw2ceil.