Workaround for more Int128-and-float methods on Windows with LLVM 14+#13218
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Mar 24, 2023
Merged
Conversation
HertzDevil
added
kind:bug
beta-ziliani
approved these changes
Mar 23, 2023
Member
beta-ziliani
left a comment
beta-ziliani
left a comment
There was a problem hiding this comment.
Let's get this in until we fix the root issue 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is like #11551, but for other operations that are apparently touched in LLVM 14. The relevant commits are:
At this moment maybe a fix to
LLVM::ABI::X86_Win64itself is also possible? But I am not familiar enough with the C ABIs so this PR just continues adding more workarounds.