[CI] Remove cross-compiliation on Windows#13207
Merged
straight-shoota merged 4 commits intomasterfrom Mar 23, 2023
Merged
Conversation
HertzDevil
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been distributing Windows packages for a long time now, but the CI workflow was still cross-compiling from Linux.
This patch fixes that and uses https://github.com/crystal-lang/install-crystal to install the previous crystal release on Windows.
This reduces complexity in the workflow and makes it less fragile. It should also speed up the CI run because there's one less compiler build.
It's a preparatory step to upgrading the Windows builds to LLVM 15.