Fix Regex::Option behaviour for unnamed members#13155
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Mar 7, 2023
Merged
Fix Regex::Option behaviour for unnamed members#13155straight-shoota merged 2 commits intocrystal-lang:masterfrom
Regex::Option behaviour for unnamed members#13155straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:bug
Sija
reviewed
Mar 5, 2023
HertzDevil
reviewed
Mar 6, 2023
HertzDevil
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The process of decoupling
Regex::Optionfrom specific lib values caused an unintended behavioural change with regards to unnamed members.The intention was that unnamed members should continue to function for PCRE, but raise on PCRE2 as a safety mechanism to avoid unintended effects because both library versions use different option values.
More explanation in #13152 (comment)
This was originally implemented in #12802 for the original PCRE bindings and subsequently for the PCRE2 bindings in #12856. Both implementations use
Enum#eachto iterate the flag enum members, but that only accounts for named members and excess flag values would be ignored.This patch fixes that to the intended behaviour and adds a spec for it.
The general subject is due to further discussion in #13152, though.