Skip to content

Build PCRE2 on Windows#12847

Merged
straight-shoota merged 14 commits intocrystal-lang:masterfrom
HertzDevil:feature/pcre2-windows
Jan 4, 2023
Merged

Build PCRE2 on Windows#12847
straight-shoota merged 14 commits intocrystal-lang:masterfrom
HertzDevil:feature/pcre2-windows

Conversation

@HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Dec 16, 2022

Builds pcre2-8.lib and distributes it alongside pcre.lib for Windows packages.

This makes Crystal always prefer PCRE2 on Windows by default, because there is no pkg-config here.

@HertzDevil HertzDevil added kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:text labels Dec 16, 2022
@straight-shoota straight-shoota added this to the 1.7.0 milestone Dec 16, 2022
@HertzDevil HertzDevil removed this from the 1.7.0 milestone Dec 16, 2022
@HertzDevil
Copy link
Contributor Author

@straight-shoota feel free to include this patch as part of the new PCRE2 PR directly

@straight-shoota straight-shoota mentioned this pull request Dec 19, 2022
10 tasks
@straight-shoota straight-shoota changed the base branch from master to feature/pcre2 December 21, 2022 13:13
@straight-shoota
Copy link
Member

I rebased this on top of the new PR for PCRE2 (#12856). But it doesn't work as is.

In #12856 PCRE2 is not chosen by default. It's opt-in via -Duse_pcre2 for now. And for now we also shouldn't build the compiler with PCRE2. We're not doing that on other platforms yet either, and it affects the syntax of the language (#12857).

We could run regex specs against PCRE2 on windows. But I suppose the specs from #12856 should be sufficient for that. I don't expect different behaviour from PCRE2 on other platforms.

@straight-shoota straight-shoota deleted the branch crystal-lang:master December 22, 2022 20:35
@straight-shoota
Copy link
Member

Looks like this was claused automatically by merging #12856. No idea why. The target branch should've just rebased (as did #12866 (comment)).

@oprypin
Copy link
Member

oprypin commented Dec 23, 2022

Yeah GitHub behaves weirdly.
Now what you can do is undelete the branch then manually change the base here

@straight-shoota straight-shoota changed the base branch from feature/pcre2 to master December 23, 2022 11:14
@straight-shoota
Copy link
Member

This is so weird. But it works 🤷 Thanks @oprypin 👍

@straight-shoota straight-shoota added this to the 1.7.0 milestone Jan 3, 2023
@straight-shoota straight-shoota merged commit 2354ad5 into crystal-lang:master Jan 4, 2023
@HertzDevil HertzDevil deleted the feature/pcre2-windows branch January 8, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:text

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants