Add missing positive spec for Regex#match with option#12804
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Nov 30, 2022
Merged
Add missing positive spec for Regex#match with option#12804straight-shoota merged 1 commit intocrystal-lang:masterfrom
Regex#match with option#12804straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
oprypin
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #12788.
A "positive" test case for
Regex#matchwith an option argument etc. was missing. And this was exactly where a silent bug in the refactoring of #12802 appeared, that was not caught be the regex spec (but string_scanner spec, fortunately).