Re-organize and enhance specs for Regex::MatchData#12789
Merged
straight-shoota merged 9 commits intocrystal-lang:masterfrom Nov 29, 2022
Merged
Re-organize and enhance specs for Regex::MatchData#12789straight-shoota merged 9 commits intocrystal-lang:masterfrom
Regex::MatchData#12789straight-shoota merged 9 commits intocrystal-lang:masterfrom
Conversation
This was referenced Nov 27, 2022
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is a big overhaul of
Regex::MatchDataspecs, improving both the structure of the tests as well as adding some specs for previously untested behaviour.The changes affect nearly all lines and the file is moved to
spec/std/regex, but following the individual commits should make it easy to understand each set of changes. The first commit (2a11e1d) is just a rename and does not change the contents of the file (GitHub UI still doesn't seem to recognize the renamed file for the branch diff).See #12788 for similar changes for
Regexspecs.