Revert some additions of free variables to type restrictions#11246
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Sep 30, 2021
Merged
Revert some additions of free variables to type restrictions#11246straight-shoota merged 2 commits intocrystal-lang:masterfrom
straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:bug
Member
|
It would be nice to have some specs so we make sure nobody adds them back again. Or maybe a comment in the source code. |
straight-shoota
approved these changes
Sep 25, 2021
Contributor
|
It looks reasonable to include in 1.2.0, since this fixes an issue from #10467 which is part of 1.2.0 milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11244. Reverts part of #10467 where generic type restrictions like
Foowere changed intoFoo(T) forall T, as they are not equivalent.