Syntax errors for invalid 128-bit integer literals#10975
Merged
straight-shoota merged 7 commits intocrystal-lang:masterfrom Aug 23, 2021
rymiel:128integers
Merged
Syntax errors for invalid 128-bit integer literals#10975straight-shoota merged 7 commits intocrystal-lang:masterfrom rymiel:128integers
straight-shoota merged 7 commits intocrystal-lang:masterfrom
rymiel:128integers
Conversation
Blocked by the TODOs in the NumberLiteral codegen visitor
straight-shoota
approved these changes
Jul 20, 2021
Member
|
Thanks. Parser warnings are really fine for now. Full 128-bit support is a more complex story (#8373). |
Sija
reviewed
Jul 20, 2021
Contributor
Sija
left a comment
There was a problem hiding this comment.
Missing indentation suggestions.
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
straight-shoota
approved these changes
Jul 24, 2021
sdogruyol
approved these changes
Aug 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10962
Since I am not skilled enough to resolve these TODOs in the codegen, I simply opted to warn about not being allowed to use literals larger than a 64-bit integer
crystal/src/compiler/crystal/codegen/codegen.cr
Lines 453 to 458 in 71d6e9b