Remove incorrect type restrictions on index methods with offset#10972
Merged
straight-shoota merged 4 commits intocrystal-lang:masterfrom Jul 22, 2021
Merged
Conversation
straight-shoota
added
kind:bug
Contributor
|
Just ran into this yesterday and started making changes for a PR. You beat me to it 😉 I wonder how many more regressions like this there are |
asterite
approved these changes
Jul 20, 2021
sdogruyol
approved these changes
Jul 20, 2021
Member
sdogruyol
left a comment
sdogruyol
left a comment
There was a problem hiding this comment.
Thank you @straight-shoota 🙏
…nt32?` return type `Slice(UInt8)#index(UInt8, Int)` delegates to `Slice#fast_index` which has a return type of `Int32` but the compiler would not be able to figure that out and merge in the type of `offset` into the union.
straight-shoota
added a commit
that referenced
this pull request
Jul 23, 2021
syeopite
added a commit
to iv-org/invidious
that referenced
this pull request
Aug 12, 2021
This reverts commit f2b69fd. Crystal 1.1.0 is not supported by Invidious due to upstream issue. See crystal-lang/crystal#10972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10583 introduced return type restrictions to
indexmethods that are not correct, because the return type depends on the type of theoffsetparameter.Resolves #10969