Skip to content

Update previous release Crystal 1.1.0#10955

Merged
straight-shoota merged 3 commits intomasterfrom
ci/update-previous-release
Jul 20, 2021
Merged

Update previous release Crystal 1.1.0#10955
straight-shoota merged 3 commits intomasterfrom
ci/update-previous-release

Conversation

@straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jul 16, 2021

Still waiting on 1.1.0 docker images

@straight-shoota straight-shoota marked this pull request as ready for review July 17, 2021 10:39
@straight-shoota
Copy link
Member Author

Specs are failing due to #10961, but that's fine (for this PR).

@@ -1 +1 @@
1.1.0
1.2.0-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 1.1.1? I think we have at least one fix for that version.

Copy link
Member Author

@straight-shoota straight-shoota Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The master branch should be heading towards the next minor release. We shouldn't keep it frozen any longer (it's been a month now).

If we need patch releases, the bugfixes would be backported to the release/1.1 branch.
What fix do you have in mind?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I guess #10960?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that one. But I can't remember how branches and releases work, so better to ignore me 😅

Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shas in shell.nix needs to be updated $ nix-prefetch-url --unpack <url>

Other than that LGTM

Co-authored-by: Brian J. Cardiff <bcardiff@manas.tech>
@straight-shoota straight-shoota added this to the 1.2.0 milestone Jul 19, 2021
@straight-shoota
Copy link
Member Author

straight-shoota commented Jul 20, 2021

There are still a lot of CI failures, even after #10964 has been merged.

I think we should still merge this. Red CI isn't a huge issue (especially at the beginning of a release cycle) and it helps avoid regressions like #10971.

@straight-shoota straight-shoota merged commit 0f2b71d into master Jul 20, 2021
@straight-shoota straight-shoota deleted the ci/update-previous-release branch July 20, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants