Refactor block type restriction underscore output to nil#10938
Draft
straight-shoota wants to merge 1 commit intocrystal-lang:masterfrom
Draft
Refactor block type restriction underscore output to nil#10938straight-shoota wants to merge 1 commit intocrystal-lang:masterfrom
straight-shoota wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
Member
|
I wonder if it would break things to explicit the |
Member
Author
|
Nil and empty should be semantically equivalent here. We could use |
Member
|
right, but given that the semantics are somewhat not entirely there, maybe it makes sense to be explicit for once |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch replaces underscore output types in block restrictions with nil (empty) for methods where the result of the yielded block is irrelevant and unused. Underscore should be used where the result type is not specified but the value is actually used.
See #10931
This had previously been a part of #10929