Add block type restriction to Iterator#each#10905
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Jul 12, 2021
Merged
Add block type restriction to Iterator#each#10905straight-shoota merged 1 commit intocrystal-lang:masterfrom
Iterator#each#10905straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:bug
asterite
approved these changes
Jul 8, 2021
Member
asterite
left a comment
asterite
left a comment
There was a problem hiding this comment.
Looks good! I think we can include this for 1.1, I consider it a bug fix, as you mentioned.
Member
Author
|
This change caused another build break in This time it doesn't seem to be a bug in Fix is in #10928. Alternatively, we can revert this PR. |
This was referenced Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iterator#eachimplementsEnumerable#each, but does not apply the same type restriction on the block argument. The compiler currently does not enforce that (see #10902). This change makes the implementation's signature match the abstract def's.See #10857 (comment) for details.
There are more implementations of
Enumerable#eachin stdlib which should get the same type restriction. But I encountered some issues with that, so it'll be deferred.Iterator#eachseems to be fine though, at least with stdlib specs.