Fix Socket::Connect error in addrinfo inherit os_error #10782
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Jun 13, 2021
Merged
Fix Socket::Connect error in addrinfo inherit os_error #10782straight-shoota merged 2 commits intocrystal-lang:masterfrom
straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
os_error value may be nil, hence the message can be nil, too
straight-shoota
added
kind:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is necessary, because
errnomay not actually have the corresponding value anymore, and the reliance onErrnois not portable.The first commit changes
SystemError.new_from_os_errorto allowmessageparameter be nil.os_errorin.from_os_errormay be nil, hence the message can be nil, too.