Refactor Socket::Addrinfo::Error based on os_error #10761
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Jun 4, 2021
Merged
Refactor Socket::Addrinfo::Error based on os_error #10761straight-shoota merged 2 commits intocrystal-lang:masterfrom
Socket::Addrinfo::Error based on os_error #10761straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:feature
kind:refactor
breaking-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addrinfo::Errorused to have an extra ivarerror_codeto keep track of the error code. This patch refactors the class to useSystemError#os_errorand the associated factory methods instead, which is exactly made for this purpose.Addrinfo::Erroralready inheritsSystemErrorthroughSocket::Error, so this doesn't change the type hierarchy.As a result,
Addrinfo::Error#valueand theAddrinfoconstructors receiving a plainInt32error code are being deprecated (they keep working as delegates to the respectiveSystemErrormethods.A necessary addition to
SystemError(first commit) is the factory method.os_error_messagewhich allows customization of the error message constructed from theos_errorvalue (which was previously hardcoded toos_error.message). This allows incorporation ofoptsvalues into the message.